Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "domain" from directory query params #259

Merged
merged 3 commits into from
Jun 6, 2024

Conversation

ameesha
Copy link
Contributor

@ameesha ameesha commented Jan 19, 2024

Description

We no longer support "domain" as a query param moving forward.

Documentation

Does this require changes to the WorkOS Docs? E.g. the API Reference or code snippets need updates.

[ ] Yes

If yes, link a related docs PR and add a docs maintainer as a reviewer. Their approval is required.

@codecov-commenter
Copy link

codecov-commenter commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.53%. Comparing base (2a92fad) to head (03fc89c).
Report is 22 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #259   +/-   ##
=======================================
  Coverage   95.53%   95.53%           
=======================================
  Files          42       42           
  Lines         940      940           
=======================================
  Hits          898      898           
  Misses         42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mattgd mattgd added the breaking change Contains a breaking change label May 29, 2024
@mattgd mattgd self-assigned this Jun 6, 2024
@mattgd mattgd merged commit 519531a into main Jun 6, 2024
4 checks passed
@mattgd mattgd deleted the remove-domain-from-dir-query-params branch June 6, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Contains a breaking change
Development

Successfully merging this pull request may close these issues.

4 participants