Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add profile_picture_url attribute to the User object #260

Merged
merged 2 commits into from
Feb 7, 2024

Conversation

mthadley
Copy link
Contributor

@mthadley mthadley commented Feb 6, 2024

Description

Adds the new profile_picture_url field to the Ruby SDK User object.

Documentation

Does this require changes to the WorkOS Docs? E.g. the API Reference or code snippets need updates.

[x] Yes

If yes, link a related docs PR and add a docs maintainer as a reviewer. Their approval is required.

Copy link

linear bot commented Feb 6, 2024

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ac5c70d) 97.24% compared to head (24b0161) 97.25%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #260   +/-   ##
=======================================
  Coverage   97.24%   97.25%           
=======================================
  Files          56       56           
  Lines        1345     1347    +2     
=======================================
+ Hits         1308     1310    +2     
  Misses         37       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now I only updated this cassette so that we at least have some kind of smoke test for when the new field is returned.

I think it would be a larger endeavor to update the rest of the cassettes that have User objects.

@mthadley mthadley requested review from hadihallak, a team and tribble and removed request for a team February 7, 2024 02:01
@hadihallak hadihallak merged commit 00979f9 into main Feb 7, 2024
1 check passed
@hadihallak hadihallak deleted the feature/auth-2740-add-to-ruby-sdk branch February 7, 2024 14:20
@hadihallak hadihallak mentioned this pull request Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants