Add "role" to organization membership and directory sync user #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ameesha
requested review from
mattgd,
a team and
mthadley
and removed request for
a team
PaulAsjes
approved these changes
Jun 24, 2024
Merged
georg
reviewed
Jun 26, 2024
Comment on lines
+869
to
+873
| def update_organization_membership(organization_membership_id:, role_slug:) | ||
| request = put_request( | ||
| path: "/user_management/organization_memberships/#{id}", | ||
| body: { | ||
| organization_membership_id: organization_membership_id, |
There was a problem hiding this comment.
The API expects an id field in the body, not organization_membership_id.
Also line 871 references an id variable which is not defined in this method.
I suggest renaming the parameter from organization_membership_id to id to keep parity with the delete_organization_membership method.
There was a problem hiding this comment.
Sorry about that, fixed in the 5.2.1 patch
https://rubygems.org/gems/workos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add "role" property to both "organization_membership" (non nullable) and "directory_user" (nullable)
Also added update_organization_membership method
and updated "created_organization_membership" method to accept role_slug
Documentation
Does this require changes to the WorkOS Docs? E.g. the API Reference or code snippets need updates.
If yes, link a related docs PR and add a docs maintainer as a reviewer. Their approval is required.