Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make idp_id for Profiles nilable #45

Merged
merged 3 commits into from
Aug 17, 2020
Merged

Make idp_id for Profiles nilable #45

merged 3 commits into from
Aug 17, 2020

Conversation

rohanjadvani
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Aug 17, 2020 •
edited
Loading

Codecov Report

Merging #45 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #45   +/-   ##
=======================================
  Coverage   98.49%   98.49%           
=======================================
  Files          13       13           
  Lines         265      265           
=======================================
  Hits          261      261           
  Misses          4        4
Impacted Files Coverage Δ
lib/workos/profile.rb 92.00% <100.00%> (ø)
lib/workos/types/profile_struct.rb 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cccafe...f861153. Read the comment docs.

@rohanjadvani rohanjadvani merged commit e3a4ec7 into master Aug 17, 2020
@rohanjadvani rohanjadvani deleted the rohanjadvani/update-profile-types branch August 17, 2020 17:06
blairworkos pushed a commit that referenced this pull request Jan 29, 2021
@willmanduffy
Make idp_id for Profiles nilable (#45)
6d39cc1 
* Make `idp_id` nilable

* Bump gem to 0.4.2

* Make `idp_id` nil in initialize

Co-authored-by: Willman Duffy <willman@workos.com>
blairworkos pushed a commit that referenced this pull request Mar 3, 2021
@willmanduffy
Make idp_id for Profiles nilable (#45)
31442fe 
* Make `idp_id` nilable

* Bump gem to 0.4.2

* Make `idp_id` nil in initialize

Co-authored-by: Willman Duffy <willman@workos.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willmanduffy willmanduffy willmanduffy approved these changes

@marktran marktran Awaiting requested review from marktran

@henrylamchan henrylamchan Awaiting requested review from henrylamchan

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rohanjadvani @willmanduffy