Node/EVM: Track latest block #3470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruce-riley
force-pushed
the
node/evm_track_latest_block
branch
from
a7d2076
to
b6ab5df
Compare
panoel
changed the title
bruce-riley
force-pushed
the
node/evm_track_latest_block
branch
3 times, most recently
from
e17bd21
to
5b4918a
Compare
bruce-riley
changed the title
bruce-riley
requested review from
evan-gray,
panoel and
kev1n-peters
as code owners
panoel
reviewed
Oct 30, 2023
panoel
reviewed
Oct 30, 2023
panoel
reviewed
Oct 30, 2023
panoel
reviewed
Oct 30, 2023
panoel
previously approved these changes
Oct 30, 2023
evan-gray
requested changes
Oct 30, 2023
bruce-riley
force-pushed
the
node/evm_track_latest_block
branch
from
1ee8654
to
aa31d1d
Compare
bruce-riley
force-pushed
the
node/evm_track_latest_block
branch
2 times, most recently
from
392a874
to
9458000
Compare
panoel
previously approved these changes
Nov 1, 2023
evan-gray
force-pushed
the
node/evm_track_latest_block
branch
from
9458000
to
be71ef8
Compare
evan-gray
requested changes
Nov 2, 2023
panoel
approved these changes
Nov 2, 2023
evan-gray
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the EVM watcher so that it publishes latest, safe and finalized blocks for all chains. These are published in the gossip heartbeats and in Prometheus metrics.
This PR does the following:
BatchPollConnectorwhich uses batch RPC calls to query chains that support querying forfinalizedandsafe.EthereumConnectorandCeloConnectorpublish each block aslatest,safeandfinalized.finalizedtag (currently only Neon), the existingBlockPollConnectorthat uses a finalizer was modified to also publish latest and safe, in addition to the current finalized.The result of this PR is that every chain now publishes all three finality types, where if the chain does not provide a query for
safe, it is published when the block is finalized.