node: Add cache buster for CoinGecko price queries #3528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djb15
force-pushed
the
node/coingecko-cache
branch
from
1617afc
to
0764e2f
Compare
SEJeff
approved these changes
Nov 14, 2023
bruce-riley
approved these changes
Nov 21, 2023
|
Thanks for the suggestion to test with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably overkill but my thinking was that since price queries are every 15 minutes, someone could predict the cache key if just the Unix timestamp was used; hence concatenating the unix timestamp and a random number.
Tested cache hits/misses with Postman