From 193e65e8cd1237c1b3922acc3ec0245871d6347b Mon Sep 17 00:00:00 2001 From: James Tanner Date: Sun, 8 Jan 2023 16:13:47 -0500 Subject: [PATCH] Ignore pyroblast delay when not doing fireball rotation --- sim/mage/mage.go | 2 +- ui/mage/inputs.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/sim/mage/mage.go b/sim/mage/mage.go index 45678e3e3b..59db2da415 100644 --- a/sim/mage/mage.go +++ b/sim/mage/mage.go @@ -170,7 +170,7 @@ func NewMage(character core.Character, options *proto.Player) *Mage { if mage.Talents.ImprovedScorch == 0 { mage.Rotation.MaintainImprovedScorch = false } - if !mage.Options.IgniteMunching { + if !mage.Options.IgniteMunching || mage.Rotation.PrimaryFireSpell != proto.Mage_Rotation_Fireball { mage.PyroblastDelayMs = 0 } diff --git a/ui/mage/inputs.ts b/ui/mage/inputs.ts index 91d5bf9800..b5df3a5672 100644 --- a/ui/mage/inputs.ts +++ b/ui/mage/inputs.ts @@ -130,7 +130,7 @@ export const MageRotationConfig = {

Adds a delay to Pyroblast after a Hot Streak to prevent ignite munching. 50ms is a good default for this.

There is no way to do this perfectly in-game, but a cqs macro can do this with about 70-90% reliability.

`, - showWhen: (player: Player) => player.getRotation().type == RotationType.Fire && player.getSpecOptions().igniteMunching, + showWhen: (player: Player) => player.getRotation().type == RotationType.Fire && player.getRotation().primaryFireSpell == PrimaryFireSpell.Fireball && player.getSpecOptions().igniteMunching, changeEmitter: (player: Player) => TypedEvent.onAny([player.rotationChangeEmitter, player.specOptionsChangeEmitter]), }), // ********************************************************