Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to wp-cli/wp-cli-tests:^4 #42

Merged
merged 4 commits into from
Aug 30, 2023
Merged

Update to wp-cli/wp-cli-tests:^4 #42

merged 4 commits into from
Aug 30, 2023

Conversation

danielbachhuber
Copy link
Member

@danielbachhuber danielbachhuber commented Aug 30, 2023 •
edited
Loading

@danielbachhuber danielbachhuber added this to the 2.0.3 milestone Aug 30, 2023
@danielbachhuber danielbachhuber self-assigned this Aug 30, 2023
@danielbachhuber danielbachhuber requested a review from a team as a code owner August 30, 2023 11:58
@swissspidy
Copy link
Member 

Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$wp_admin".

Should we perhaps disable that rule in the ruleset?

@danielbachhuber
Copy link
Member Author

Should we perhaps disable that rule in the ruleset?

@swissspidy Fixed with 3f592b0

@swissspidy swissspidy merged commit e2e1635 into main Aug 30, 2023
32 checks passed
@swissspidy swissspidy deleted the update-wp-cli-tests-v4 branch August 30, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swissspidy swissspidy swissspidy approved these changes

Assignees

@danielbachhuber danielbachhuber

Labels
scope:testing
Projects
None yet
Milestone
2.0.3
Development

Successfully merging this pull request may close these issues.
2 participants
@danielbachhuber @swissspidy