Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add edge case handling checksum verification of Hello Dolly #119

Merged
merged 3 commits into from
Nov 10, 2023
Merged

Add edge case handling checksum verification of Hello Dolly #119

merged 3 commits into from
Nov 10, 2023

Conversation

shawnhooper
Copy link
Contributor

Fixes: #33
Related: wp-cli/wp-cli#5859

@shawnhooper shawnhooper marked this pull request as ready for review November 10, 2023 21:33
@shawnhooper shawnhooper requested a review from a team as a code owner November 10, 2023 21:33
@danielbachhuber danielbachhuber added this to the 2.2.5 milestone Nov 10, 2023
danielbachhuber
danielbachhuber approved these changes Nov 10, 2023
View reviewed changes
Copy link
Member

@danielbachhuber danielbachhuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great 🎉 Thanks, @shawnhooper!

@danielbachhuber danielbachhuber merged commit f691199 into wp-cli:main Nov 10, 2023
36 checks passed
@shawnhooper shawnhooper deleted the 33-hello-dolly branch November 10, 2023 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielbachhuber danielbachhuber danielbachhuber approved these changes

Assignees
No one assigned
Labels
command:plugin-verify-checksums
Projects
None yet
Milestone
2.2.5
Development

Successfully merging this pull request may close these issues.

Provide hardcoded edge case for hello plugin installed by Core
2 participants
@shawnhooper @danielbachhuber