Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to WPCS v3 #110

Merged
merged 8 commits into from
Aug 30, 2023
Merged

Update to WPCS v3 #110

merged 8 commits into from
Aug 30, 2023

Conversation

schlessera
Copy link
Member

@schlessera schlessera commented Aug 30, 2023 •
edited by danielbachhuber
Loading

Auto-generated PR that updates WPCS to the latest v3 and then fixes all automatically fixable issues.

See wp-cli/wp-cli-tests#175

@schlessera schlessera requested a review from a team as a code owner August 30, 2023 13:32
@swissspidy swissspidy mentioned this pull request Aug 30, 2023
Closed
@danielbachhuber danielbachhuber added this to the 2.1.12 milestone Aug 30, 2023
@danielbachhuber danielbachhuber mentioned this pull request Aug 30, 2023
Closed
jrfnl
jrfnl reviewed Aug 30, 2023
View reviewed changes
Copy link

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ruleset still needs an update:

export-command/phpcs.xml.dist

Lines 67 to 69 in b527d8b

<rule ref="WordPress.WP.CapitalPDangit.Misspelled">
<exclude-pattern>*/src/Export_Command\.php$</exclude-pattern>
</rule>

I suspect changing the error code to WordPress.WP.CapitalPDangit.MisspelledInComment should work for you.

jrfnl
jrfnl reviewed Aug 30, 2023
View reviewed changes
Copy link

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also looks like you still need to update a few inline ignore annotations for sniffs which have been swopped out for other sniffs.

Most notably WordPress.CodeAnalysis.AssignmentInCondition.FoundInWhileCondition has become Generic.CodeAnalysis.AssignmentInCondition.FoundInWhileCondition.

@danielbachhuber
Copy link
Member

Unrelated build failure

@danielbachhuber danielbachhuber merged commit c0dec81 into main Aug 30, 2023
31 of 32 checks passed
@danielbachhuber danielbachhuber deleted the fix/wpcs-3.0-issues branch August 30, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrfnl jrfnl jrfnl left review comments

@danielbachhuber danielbachhuber danielbachhuber approved these changes

Assignees
No one assigned
Labels
scope:testing
Projects
None yet
Milestone
2.1.12
Development

Successfully merging this pull request may close these issues.
3 participants
@schlessera @danielbachhuber @jrfnl