Support for Composer 2.5

[danielbachhuber]

We should update wp-cli/package-command so it can be installed where composer/composer 2.5 is a dependency.

From #167 (comment)

Done is:

• wp-cli/package-command supports composer/composer:~2.5.

[stefanfisk]

@danielbachhuber do you know anything specific that needs fixing, or is it just untested?

[danielbachhuber]

@stefanfisk I think some fixes are needed for this: https://github.com/wp-cli/package-command/actions/runs/4189588371/jobs/7262087460#step:13:318

[stefanfisk]

@danielbachhuber cool, that looks easy enough. Is it OK to go with only ^2.5.4, or is ^1.10.23 still needed as well?

[danielbachhuber]

@stefanfisk We can remove ^1.10.23 as long as there aren't any backwards-compat issues.

[stefanfisk]

@danielbachhuber so after making the changes required I found some old related issues where this exact change was abandoned because Composer 2.3 is not compatible with PHP 5.6: #151 #152

So as long as PHP 5.6 compatibility is required this is not fixable. I'm not familiar with the PHP compatibility policy for WP-CLI, is PHP 5.6 compatiblity still required? And if it is, is there any end date for said compatiblity requirement? 5.6 is absolutely ancient by now :/

[danielbachhuber]

so after making the changes required I found some old related issues where this exact change was abandoned because Composer 2.3 is not compatible with PHP 5.6:

@stefanfisk Ah, good find.

So as long as PHP 5.6 compatibility is required this is not fixable. I'm not familiar with the PHP compatibility policy for WP-CLI, is PHP 5.6 compatiblity still required? And if it is, is there any end date for said compatiblity requirement? 5.6 is absolutely ancient by now :/

We'll need to support support PHP 5.6 at least as long as WordPress core supports 5.6. Fortunately, that should be over soon.

In 2019, our plan was to support PHP 5.6 for at least a year after core removed support. It seems like we may need to revisit that, though.

[stefanfisk]

As a workaround, I switch from wp-cli-bundle to requiring the individual packages except for package-command.

It's a bit ugly, but would you be OK with having to implementations of ComposerIO, one with types and one without, and then have ComposerIO.php require the correct one based on PHP_MAJOR_VERSION?

[danielbachhuber]

It's a bit ugly, but would you be OK with having to implementations of ComposerIO, one with types and one without, and then have ComposerIO.php require the correct one based on PHP_MAJOR_VERSION?

@stefanfisk Yes, that would be a perfectly fine approach