Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility with newer Composer versions #183

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

schlessera
Copy link
Member

Fixes #172
Supersedes wp-cli/wp-cli#5757

This PR adds a compatiblity shim for ComposerIO\NullIO so that it works with Composer 2.3+ which added type declarations and thereby changed method signatures and broke BC.

This PR moves the ComposerIO class over from the wp-cli/wp-cli. This seems to have been a left-ver from when the original WP-CLI monorepo was split up.

The PR also removes the upper limit on the Composer version now, and was successfully tested with Composer 2.6+.

Props to @stefanfisk for a lot of the initial digging and work on the previous PR.

@schlessera schlessera requested a review from a team as a code owner December 8, 2023 10:27
@schlessera schlessera added this to the 2.5.0 milestone Dec 8, 2023
@schlessera schlessera merged commit 7168319 into main Dec 8, 2023
65 checks passed
@schlessera schlessera deleted the fix/add-composer-compat-for-2-3 branch December 8, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Composer 2.5
2 participants