Prefer Packagist over GitHub #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When installing a package, Packagist will now be searched first. When GitHub is chosen, the WP-CLI will try to guess how to interpret the `@stable` tag and produce a verson constraint out of it. Fixes #90
wojsmol
reviewed
Aug 7, 2018
| @@ -725,7 +729,14 @@ private function get_package_by_shortened_identifier( $package_name ) { | |||
| } | |||
| } | |||
|
|
|||
| // Fall back to GitHub URL if we had no match in the package index. | |||
| // Check if the package exists on Packagist. | |||
| $url = "https://repo.packagist.org/p/{$package_name}.json"; | |||
There was a problem hiding this comment.
This url is wrong - https://github.com/composer/composer/releases/tag/1.7.0
There was a problem hiding this comment.
actually I was wrong above not the url 😄
To test the GitHub functionality, we need a custom commands stored in a GitHub repository that is not indexed in Packagist. As Packagist does not prune old data when yuo `Delete` a repo, we need a new one that won't go into Packagist.
schlessera
added a commit
that referenced
this pull request
Jan 5, 2022
Prefer Packagist over GitHub
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When installing a package, Packagist will now be searched first.
When GitHub is chosen, the WP-CLI will try to guess how to interpret the
@stabletag and produce a version constraint out of it.Fixes #90