From a059bf979af23e4700127fb1a05289a4b159f378 Mon Sep 17 00:00:00 2001
From: Pascal Birchler <pascalb@google.com>
Date: Wed, 30 Aug 2023 14:38:26 +0200
Subject: [PATCH 1/4] Rename property

---
 WP_CLI_CS/ruleset.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/WP_CLI_CS/ruleset.xml b/WP_CLI_CS/ruleset.xml
index b04b28a6..88c77eef 100644
--- a/WP_CLI_CS/ruleset.xml
+++ b/WP_CLI_CS/ruleset.xml
@@ -111,7 +111,7 @@
 		 See: https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards/wiki/Customizable-sniff-properties#error-silencing-use-build-in-function-whitelist -->
 	<rule ref="WordPress.PHP.NoSilencedErrors">
 		<properties>
-			<property name="use_default_whitelist" value="true"/>
+			<property name="usePHPFunctionsList" value="true"/>
 		</properties>
 	</rule>
 

From 912ebdc36b089f2a322fc30db52925039681bbbd Mon Sep 17 00:00:00 2001
From: Pascal Birchler <pascalb@google.com>
Date: Wed, 30 Aug 2023 14:38:35 +0200
Subject: [PATCH 2/4] Update list of ignored file system operations

---
 WP_CLI_CS/ruleset.xml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/WP_CLI_CS/ruleset.xml b/WP_CLI_CS/ruleset.xml
index 88c77eef..e4a45dc3 100644
--- a/WP_CLI_CS/ruleset.xml
+++ b/WP_CLI_CS/ruleset.xml
@@ -82,6 +82,8 @@
 		<exclude name="WordPress.WP.AlternativeFunctions.file_system_operations_file_put_contents" />
 		<exclude name="WordPress.WP.AlternativeFunctions.file_system_operations_mkdir" />
 		<exclude name="WordPress.WP.AlternativeFunctions.file_system_operations_rmdir" />
+		<exclude name="WordPress.WP.AlternativeFunctions.file_system_operations_is_writable" />
+		<exclude name="WordPress.WP.AlternativeFunctions.file_system_operations_is_writeable" />
 		<exclude name="WordPress.WP.AlternativeFunctions.rename_rename" />
 		<exclude name="WordPress.WP.AlternativeFunctions.unlink_unlink" />
 

From 9fa9caede2bf4580723070ccc90029769268a2c1 Mon Sep 17 00:00:00 2001
From: Pascal Birchler <pascalb@google.com>
Date: Wed, 30 Aug 2023 17:23:35 +0200
Subject: [PATCH 3/4] Remove redundant excludes

---
 WP_CLI_CS/ruleset.xml | 23 +----------------------
 1 file changed, 1 insertion(+), 22 deletions(-)

diff --git a/WP_CLI_CS/ruleset.xml b/WP_CLI_CS/ruleset.xml
index d74dc5b6..1c92f158 100644
--- a/WP_CLI_CS/ruleset.xml
+++ b/WP_CLI_CS/ruleset.xml
@@ -77,28 +77,6 @@
 
 		<!-- Keep short ternaries around for WP-CLI. -->
 		<exclude name="Universal.Operators.DisallowShortTernary.Found"/>
-
-		<!-- Allow filesystem operations because WordPress APIs may not be available -->
-		<exclude name="WordPress.WP.AlternativeFunctions.file_system_operations_chgrp" />
-		<exclude name="WordPress.WP.AlternativeFunctions.file_system_operations_chmod" />
-		<exclude name="WordPress.WP.AlternativeFunctions.file_system_operations_chown" />
-		<exclude name="WordPress.WP.AlternativeFunctions.file_system_operations_fclose" />
-		<exclude name="WordPress.WP.AlternativeFunctions.file_system_operations_file_put_contents" />
-		<exclude name="WordPress.WP.AlternativeFunctions.file_system_operations_fopen" />
-		<exclude name="WordPress.WP.AlternativeFunctions.file_system_operations_fputs" />
-		<exclude name="WordPress.WP.AlternativeFunctions.file_system_operations_fread" />
-		<exclude name="WordPress.WP.AlternativeFunctions.file_system_operations_fsockopen" />
-		<exclude name="WordPress.WP.AlternativeFunctions.file_system_operations_fwrite" />
-		<exclude name="WordPress.WP.AlternativeFunctions.file_system_operations_is_writable" />
-		<exclude name="WordPress.WP.AlternativeFunctions.file_system_operations_is_writeable" />
-		<exclude name="WordPress.WP.AlternativeFunctions.file_system_operations_mkdir" />
-		<exclude name="WordPress.WP.AlternativeFunctions.file_system_operations_pfsockopen" />
-		<exclude name="WordPress.WP.AlternativeFunctions.file_system_operations_readfile" />
-		<exclude name="WordPress.WP.AlternativeFunctions.file_system_operations_rmdir" />
-		<exclude name="WordPress.WP.AlternativeFunctions.file_system_operations_touch" />
-		<exclude name="WordPress.WP.AlternativeFunctions.rename_rename" />
-		<exclude name="WordPress.WP.AlternativeFunctions.unlink_unlink" />
-
 	</rule>
 
 
@@ -145,6 +123,7 @@
 			<property name="exclude" type="array">
 				<element value="curl"/>
 				<element value="file_get_contents"/>
+				<!-- Allow filesystem operations because WordPress APIs may not be available -->
 				<element value="file_system_operations"/>
 				<!-- As PHP 5.4. is the minimum for most projects, using json_encode() is fine. -->
 				<element value="json_encode"/>

From 1fb543406fc43364203a171d4007df8d49a9aa0f Mon Sep 17 00:00:00 2001
From: Pascal Birchler <pascalb@google.com>
Date: Wed, 30 Aug 2023 17:30:42 +0200
Subject: [PATCH 4/4] Undo some changes

---
 WP_CLI_CS/ruleset.xml | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/WP_CLI_CS/ruleset.xml b/WP_CLI_CS/ruleset.xml
index 1c92f158..1b2da5c9 100644
--- a/WP_CLI_CS/ruleset.xml
+++ b/WP_CLI_CS/ruleset.xml
@@ -77,6 +77,10 @@
 
 		<!-- Keep short ternaries around for WP-CLI. -->
 		<exclude name="Universal.Operators.DisallowShortTernary.Found"/>
+
+		<!-- Allow filesystem operations because WordPress APIs may not be available -->
+		<exclude name="WordPress.WP.AlternativeFunctions.rename_rename" />
+		<exclude name="WordPress.WP.AlternativeFunctions.unlink_unlink" />
 	</rule>