Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github action for linting and running unit tests #38

Open
MattGeri opened this issue Sep 6, 2021 · 2 comments
Open

Github action for linting and running unit tests #38

MattGeri opened this issue Sep 6, 2021 · 2 comments
Assignees
Labels
Milestone

Comments

@MattGeri
Copy link
Contributor

MattGeri commented Sep 6, 2021

When a PR is created, a Github action should be fired to run linting (PHPCS/WPCS and JSLint/ESLint). Unit tests should also be run. A PR should not be able to be approved until the lints/tests are successful.

@jeffpaul
Copy link

jeffpaul commented Sep 8, 2021

https://github.com/10up/wpcs-action might be helpful on the PHPCS/WPCS front. The work in 10up/simple-podcasting#117 may be helpful for acceptance tests. https://github.com/10up/classifai/blob/develop/.github/workflows/lint.yml shows options for linting.

@MattGeri
Copy link
Contributor Author

MattGeri commented Sep 9, 2021

Thanks @jeffpaul! 🚀

@MattGeri MattGeri added this to the 2.4.4 milestone Feb 4, 2022
@MattGeri MattGeri self-assigned this Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants