From 2239f34b18dd6f5348797f51d786b866e441f1a0 Mon Sep 17 00:00:00 2001 From: Denis Date: Wed, 13 Oct 2021 10:41:50 +0800 Subject: [PATCH 1/2] subtract browser scrollbar width from modal overlay --- assets/scss/shared-ui/_modals.scss | 2 +- assets/scss/shared-ui/_variables.scss | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/assets/scss/shared-ui/_modals.scss b/assets/scss/shared-ui/_modals.scss index 24a111d2..c9bf95e7 100644 --- a/assets/scss/shared-ui/_modals.scss +++ b/assets/scss/shared-ui/_modals.scss @@ -23,7 +23,7 @@ // ELEMENT: Overlay mask. .sui-modal-overlay { - width: calc(100% - #{map-get($wordpress, adminmenu)}); + width: calc(100% - #{map-get($wordpress, adminmenu)} - #{($browser-scrollbar-width)}); height: calc(100vh - #{map-get($wordpress, adminbar)}); position: fixed; z-index: #{map-get($modal, z-index) - 1}; diff --git a/assets/scss/shared-ui/_variables.scss b/assets/scss/shared-ui/_variables.scss index bd0191ae..e2085b03 100644 --- a/assets/scss/shared-ui/_variables.scss +++ b/assets/scss/shared-ui/_variables.scss @@ -288,6 +288,8 @@ $onboard: ( button-md: 30px, ) !default; +$browser-scrollbar-width: 17px; + // ============================================================ // Toggles (_toggles.scss) From 2095030668a83ebfb5c76bda3ced8cacd8d3420a Mon Sep 17 00:00:00 2001 From: Denis Date: Wed, 13 Oct 2021 10:45:51 +0800 Subject: [PATCH 2/2] add default flag --- assets/scss/shared-ui/_variables.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/assets/scss/shared-ui/_variables.scss b/assets/scss/shared-ui/_variables.scss index e2085b03..399bef26 100644 --- a/assets/scss/shared-ui/_variables.scss +++ b/assets/scss/shared-ui/_variables.scss @@ -288,7 +288,7 @@ $onboard: ( button-md: 30px, ) !default; -$browser-scrollbar-width: 17px; +$browser-scrollbar-width: 17px !default; // ============================================================ // Toggles (_toggles.scss)