Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wslact: improve memory-reclaim command #271

Merged
merged 2 commits into from
Oct 2, 2023

Conversation

kbpk
Copy link
Contributor

@kbpk kbpk commented Mar 22, 2023

Currently, there is incoherence in command naming between docs, and its help command.

In the docs of the wslact in the SYNOPSIS was wslact auto-mount.
In the help command, there is an alias memory-reclaim, which doesn't exist at the moment.

Also, it is possible to increase the amount of dropping cache by calling sync before.

Description

  • in the docs, I changed mem-reclaim to memory-reclaim to keep coherence with the help command
  • added memory-reclaim, keeping mem-reclaim as the alias
  • wrote tests for memory-reclaim and mr, same as tests for other commands in the wslact
  • fixed typo reclaimation -> reclamation
  • added sync before dropping the cache

Types of changes

Breaking change (fix or feature that would cause existing functionality to not work as expected) are no longer accepted

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have read Code of Conduct and Contributing documentations.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link
Member

@patrick330602 patrick330602 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@patrick330602 patrick330602 merged commit 9cd1fc4 into wslutilities:dev/master Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants