Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pandas 1.5.0+ issue: "_take() got an unexpected keyword argument 'is_copy'" #7

Open
bccheung opened this issue Oct 3, 2022 · 2 comments
Open

pandas 1.5.0+ issue: "_take() got an unexpected keyword argument 'is_copy'" #7

bccheung opened this issue Oct 3, 2022 · 2 comments
Assignees
@aclarry @bccheung
Labels
bug Something isn't working

Comments

@bccheung
Copy link
Member

bccheung commented Oct 3, 2022

Issue encounter when performing a .loc[] operation on a LinkedDataFrame. Likely related to changes in pandas _take() starting with pandas 1.5.0.

Confirmed that issue is not present in pandas 1.4.4.

cheval/cheval/ldf/api.py

Line 635 in 03701c7

sliced: 'LinkedDataFrame' = super()._take(indices, axis=axis, is_copy=is_copy)

@bccheung bccheung added the bug Something isn't working label Oct 3, 2022
@PeterKucirek
Copy link
Collaborator

Is this related to #4 ?

@bccheung
Copy link
Member Author

bccheung commented Oct 4, 2022

We are currently taking a look at it. I think it's related, but not the same. The problem this issue brings up is the signature change in the underlying pandas function, rather than an issue with _take() itself (which is #4). This is a pandas version-specific issue.

Our plan is to address #4 first, then deal with this "lower-priority" issue afterwards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aclarry aclarry

@bccheung bccheung

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@PeterKucirek @aclarry @bccheung