From 92f5eeb6dd28120348296f7d96eb5b165266b84f Mon Sep 17 00:00:00 2001 From: "admin@noamyg.com" Date: Thu, 10 Oct 2019 14:46:20 +0300 Subject: [PATCH 1/2] Ability to pass id and class to the canvas --- README.md | 2 ++ package-lock.json | 48 +++++++++++++++++++++++++++++------------------ package.json | 12 +++++++----- signature-pad.ts | 8 ++++++++ 4 files changed, 47 insertions(+), 23 deletions(-) diff --git a/README.md b/README.md index 5a3f009..2f41e08 100644 --- a/README.md +++ b/README.md @@ -14,6 +14,8 @@ Angular 2 component for [szimek/signature_pad](https://www.npmjs.com/package/sig API is identical to [szimek/signature_pad](https://www.npmjs.com/package/signature_pad). Options are as per [szimek/signature_pad](https://www.npmjs.com/package/signature_pad) with the following additions: +* canvasId: ID of the canvas element +* canvasClass: CSS class to be added to the canvas element * canvasWidth: width of the canvas (px) * canvasHeight: height of the canvas (px) The above options are provided to avoid accessing the DOM directly from your component to adjust the canvas size. diff --git a/package-lock.json b/package-lock.json index 72cdd65..a36cd73 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,6 +1,6 @@ { "name": "angular2-signaturepad", - "version": "2.7.0", + "version": "2.9.0", "lockfileVersion": 1, "requires": true, "dependencies": { @@ -22,10 +22,10 @@ "integrity": "sha1-ZRf3B6KbZb7B4pM66Gpp6tLfBcg=", "dev": true, "requires": { - "@angular/tsc-wrapped": "0.3.0", - "minimist": "1.2.0", + "@angular/tsc-wrapped": "^0.3.0", + "minimist": "^1.2.0", "parse5": "1.3.2", - "reflect-metadata": "0.1.12" + "reflect-metadata": "^0.1.2" } }, "@angular/core": { @@ -61,7 +61,7 @@ "integrity": "sha1-mM3rXDjRRbGHwK0Dl6jZiyF/M/I=", "dev": true, "requires": { - "tsickle": "0.1.7" + "tsickle": "^0.1.7" } }, "amdefine": { @@ -106,14 +106,20 @@ "dev": true }, "rxjs": { - "version": "5.0.0-beta.12", - "resolved": "https://registry.npmjs.org/rxjs/-/rxjs-5.0.0-beta.12.tgz", - "integrity": "sha1-zf3i2MRjnSCud5S/+P3fMtp60zc=", + "version": "5.4.2", + "resolved": "https://registry.npmjs.org/rxjs/-/rxjs-5.4.2.tgz", + "integrity": "sha1-KjI2/L8D31e64G/Wly/ZnlwI/Pc=", "dev": true, "requires": { - "symbol-observable": "1.2.0" + "symbol-observable": "^1.0.1" } }, + "rxjs-compat": { + "version": "6.5.3", + "resolved": "https://registry.npmjs.org/rxjs-compat/-/rxjs-compat-6.5.3.tgz", + "integrity": "sha512-BIJX2yovz3TBpjJoAZyls2QYuU6ZiCaZ+U96SmxQpuSP/qDUfiXPKOVLbThBB2WZijNHkdTTJXKRwvv5Y48H7g==", + "dev": true + }, "signature_pad": { "version": "2.3.2", "resolved": "https://registry.npmjs.org/signature_pad/-/signature_pad-2.3.2.tgz", @@ -125,7 +131,7 @@ "integrity": "sha1-66T12pwNyZneaAMti092FzZSA2s=", "dev": true, "requires": { - "amdefine": "1.0.1" + "amdefine": ">=0.0.4" } }, "source-map-support": { @@ -143,7 +149,7 @@ "integrity": "sha1-yLbBZ3l7pHQKjqMyUhYv8IWRsmY=", "dev": true, "requires": { - "amdefine": "1.0.1" + "amdefine": ">=0.0.4" } } } @@ -160,16 +166,22 @@ "integrity": "sha1-v+j0zc2vmkC4SnKaOEgML4JPGKs=", "dev": true, "requires": { - "minimist": "1.2.0", - "mkdirp": "0.5.1", - "source-map": "0.4.4", - "source-map-support": "0.3.3" + "minimist": "^1.2.0", + "mkdirp": "^0.5.1", + "source-map": "^0.4.2", + "source-map-support": "^0.3.1" } }, + "tslib": { + "version": "1.10.0", + "resolved": "https://registry.npmjs.org/tslib/-/tslib-1.10.0.tgz", + "integrity": "sha512-qOebF53frne81cf0S9B41ByenJ3/IuH8yJKngAX35CmiZySA0khhkovshKK+jGCaMnVomla7gVlIcc3EvKPbTQ==", + "dev": true + }, "typescript": { - "version": "2.0.3", - "resolved": "https://registry.npmjs.org/typescript/-/typescript-2.0.3.tgz", - "integrity": "sha1-M97J6uhrju4yfdQZygUMhTyr1RQ=", + "version": "2.4.1", + "resolved": "https://registry.npmjs.org/typescript/-/typescript-2.4.1.tgz", + "integrity": "sha1-w8yxbdqgsjFN4DHn5v7onlujRrw=", "dev": true }, "zone.js": { diff --git a/package.json b/package.json index 149147e..3fb44b4 100644 --- a/package.json +++ b/package.json @@ -10,7 +10,7 @@ }, "repository": { "type": "git", - "url": "git+https://github.com/wulfsolter/angular2-signaturepad.git" + "url": "git+https://github.com/noamyg/angular2-signaturepad.git" }, "keywords": [ "signature", @@ -21,9 +21,9 @@ "author": "Wulf Solter (http://wulf.co.nz)", "license": "MIT", "bugs": { - "url": "https://github.com/wulfsolter/angular2-signaturepad/issues" + "url": "https://github.com/noamyg/angular2-signaturepad/issues" }, - "homepage": "https://github.com/wulfsolter/angular2-signaturepad#readme", + "homepage": "https://github.com/noamyg/angular2-signaturepad#readme", "dependencies": { "signature_pad": "2.3.2" }, @@ -35,8 +35,10 @@ "@angular/platform-browser": "2.0.1", "@angular/platform-browser-dynamic": "2.0.1", "@angular/platform-server": "2.0.1", - "rxjs": "5.0.0-beta.12", - "typescript": "2.0.3", + "rxjs": "5.4.2", + "rxjs-compat": "^6.5.3", + "tslib": "^1.10.0", + "typescript": "2.4.1", "zone.js": "0.6.25" } } diff --git a/signature-pad.ts b/signature-pad.ts index 914d976..a1aec4f 100644 --- a/signature-pad.ts +++ b/signature-pad.ts @@ -37,7 +37,15 @@ export class SignaturePad { public ngAfterContentInit(): void { let sp: any = require('signature_pad')['default']; let canvas: any = this.elementRef.nativeElement.querySelector('canvas'); + + if ((this.options)['canvasId']) { + canvas.id = (this.options)['canvasId']; + } + if ((this.options)['canvasClass']) { + canvas.classList.add((this.options)['canvasClass']); + } + if ((this.options)['canvasHeight']) { canvas.height = (this.options)['canvasHeight']; } From c4278253bd695970886bcd2283bd466172b2fac2 Mon Sep 17 00:00:00 2001 From: "admin@noamyg.com" Date: Thu, 17 Oct 2019 09:32:14 +0300 Subject: [PATCH 2/2] Refrences update package.json & package-lock.json --- package-lock.json | 24 ++++++++++++------------ package.json | 6 +++--- 2 files changed, 15 insertions(+), 15 deletions(-) diff --git a/package-lock.json b/package-lock.json index a36cd73..44207a5 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,6 +1,6 @@ { "name": "angular2-signaturepad", - "version": "2.9.0", + "version": "2.7.0", "lockfileVersion": 1, "requires": true, "dependencies": { @@ -22,10 +22,10 @@ "integrity": "sha1-ZRf3B6KbZb7B4pM66Gpp6tLfBcg=", "dev": true, "requires": { - "@angular/tsc-wrapped": "^0.3.0", - "minimist": "^1.2.0", + "@angular/tsc-wrapped": "0.3.0", + "minimist": "1.2.0", "parse5": "1.3.2", - "reflect-metadata": "^0.1.2" + "reflect-metadata": "0.1.12" } }, "@angular/core": { @@ -61,7 +61,7 @@ "integrity": "sha1-mM3rXDjRRbGHwK0Dl6jZiyF/M/I=", "dev": true, "requires": { - "tsickle": "^0.1.7" + "tsickle": "0.1.7" } }, "amdefine": { @@ -131,7 +131,7 @@ "integrity": "sha1-66T12pwNyZneaAMti092FzZSA2s=", "dev": true, "requires": { - "amdefine": ">=0.0.4" + "amdefine": "1.0.1" } }, "source-map-support": { @@ -149,7 +149,7 @@ "integrity": "sha1-yLbBZ3l7pHQKjqMyUhYv8IWRsmY=", "dev": true, "requires": { - "amdefine": ">=0.0.4" + "amdefine": "1.0.1" } } } @@ -166,10 +166,10 @@ "integrity": "sha1-v+j0zc2vmkC4SnKaOEgML4JPGKs=", "dev": true, "requires": { - "minimist": "^1.2.0", - "mkdirp": "^0.5.1", - "source-map": "^0.4.2", - "source-map-support": "^0.3.1" + "minimist": "1.2.0", + "mkdirp": "0.5.1", + "source-map": "0.4.4", + "source-map-support": "0.3.3" } }, "tslib": { @@ -191,4 +191,4 @@ "dev": true } } -} +} \ No newline at end of file diff --git a/package.json b/package.json index 3fb44b4..0d1672f 100644 --- a/package.json +++ b/package.json @@ -10,7 +10,7 @@ }, "repository": { "type": "git", - "url": "git+https://github.com/noamyg/angular2-signaturepad.git" + "url": "git+https://github.com/wulfsolter/angular2-signaturepad.git" }, "keywords": [ "signature", @@ -21,9 +21,9 @@ "author": "Wulf Solter (http://wulf.co.nz)", "license": "MIT", "bugs": { - "url": "https://github.com/noamyg/angular2-signaturepad/issues" + "url": "https://github.com/wulfsolter/angular2-signaturepad/issues" }, - "homepage": "https://github.com/noamyg/angular2-signaturepad#readme", + "homepage": "https://github.com/wulfsolter/angular2-signaturepad#readme", "dependencies": { "signature_pad": "2.3.2" },