Merge branch 'master' into cylc-linter.bk

* master: (30 commits)
  Log dir tidy (cylc#4836)
  Cut down on back-compat warnings, plus other tidying (cylc#4943)
  Validate platform settings (background job runner) (cylc#4938)
  clean: push error message to stderr
  Update cylc/flow/id_match.py
  Fix unintended directory stripping during cylc install (cylc#4931)
  stop cylc validate swallowing useful errors (cylc#4936)
  Improve config reference docs (cylc#4916)
  glblcfg: increase default rolling archive length
  Fix job state with pre-submitted failure
  Update tests/functional/cylc-reinstall/02-failures.t
  reinstall: require workflow ID argument
  play: upgrade --start-task's specified in legacy format (cylc#4925)
  expand schema docstring internally (cylc#4926)
  Added a new task filtering test.
  Add comment [skip ci]
  Fix optparse Options class for std options (cylc#4919)
  uid: warn if the run number is provided as a cycle
  Tweak prev.
  Fix task filtering.
  ...

.github/workflows/test_functional.yml

@@ -225,7 +225,7 @@ jobs:
         run: |
           find "$HOME/cylc-run" -name '*.err' -type f \
               -exec echo '====== {} ======' \; -exec cat '{}' \;
-          find "$HOME/cylc-run" -name 'log.*' -type f \
+          find "$HOME/cylc-run" -name '*.log' -type f \
               -exec echo '====== {} ======' \; -exec cat '{}' \;
           find "${TMPDIR:-/tmp}/${USER}/cylctb-"* -type f \
               -exec echo '====== {} ======' \; -exec cat '{}' \;

CHANGES.md

@@ -35,6 +35,14 @@ Fourth Release Candidate for Cylc 8 suitable for acceptance testing.
 
 ### Enhancements
 
+[#4836](https://github.com/cylc/cylc-flow/pull/4836) - The log directory has
+been tidied. Workflow logs are now found in `log/scheduler` rather than
+`log/workflow`, filenames now include `start`/`restart`. Other minor directory
+changes. Remote file installation logs are now per install target.
+
+[#4938](https://github.com/cylc/cylc-flow/pull/4938) - Detect bad Platforms
+config: background and at job runners should have a single host.
+
 [#4877](https://github.com/cylc/cylc-flow/pull/4877) - Upgrade the version of
 Jinja2 used by Cylc from 2.11 to 3.0.
 
@@ -49,6 +57,18 @@ with upgrading Cylc 7 workflows to Cylc 8: Try `cylc 728 <workflow-dir>`.
 
 ### Fixes
 
+[#4936](https://github.com/cylc/cylc-flow/pull/4936) - Fix incorrect
+error messages when workflow CLI commands fail.
+
+[#4941](https://github.com/cylc/cylc-flow/pull/4941) - Fix job state for
+platform submit-failures.
+
+[#4931](https://github.com/cylc/cylc-flow/pull/4931) - Fix cylc install for
+installing workflows from multi-level directories.
+
+[#4926](https://github.com/cylc/cylc-flow/pull/4926) - Fix a docstring
+formatting problem presenting in the UI mutation flow argument info.
+
 [#4891](https://github.com/cylc/cylc-flow/pull/4891) - Fix bug that could cause
 past jobs to be omitted in the UI.
 
@@ -80,7 +100,6 @@ the `--reflow` option from earlier pre-release versions.
 [#4743](https://github.com/cylc/cylc-flow/pull/4743) - On stopping a specific
 flow, remove active-waiting tasks with no remaining flow numbers.
 
-
 [#4854](https://github.com/cylc/cylc-flow/pull/4854)
 - Expansion and merger of comma separated platform definitions permitted.
 - Platform definition regular expressions which match "localhost" but are not

cylc/flow/__init__.py

@@ -20,13 +20,10 @@
 
 
 CYLC_LOG = 'cylc'
-FILE_INSTALL_LOG = 'cylc-rsync'
 
 LOG = logging.getLogger(CYLC_LOG)
-RSYNC_LOG = logging.getLogger(FILE_INSTALL_LOG)
 # Start with a null handler
-for log in (LOG, RSYNC_LOG):
-    log.addHandler(logging.NullHandler())
+LOG.addHandler(logging.NullHandler())
 
 LOG_LEVELS = {
     "INFO": logging.INFO,