From 7a4679c19e905a7831200c1b34138a40d7b6f91b Mon Sep 17 00:00:00 2001 From: Ilya Radchenko Date: Tue, 14 Mar 2017 11:00:20 -0400 Subject: [PATCH] Cleanup (#214) * Cleanup * More --- text/0000-custom-components.md | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/text/0000-custom-components.md b/text/0000-custom-components.md index 385b7d00d72..49709fc40a2 100644 --- a/text/0000-custom-components.md +++ b/text/0000-custom-components.md @@ -48,7 +48,7 @@ Since those proposals, we have rewritten Ember's rendering engine from the groun up (the "Glimmer 2" project). One of the goals of the Glimmer 2 effort was to build first-class primitives for our view-layer features in the rendering engine. As part of the process, we worked to rationalize these features and to re-think -the role of components in Ember.js. This execrise has brought plenty of new ideas +the role of components in Ember.js. This exercise has brought plenty of new ideas and constraints to the table. The initial Glimmer 2 integration was completed in [November](http://emberjs.com/blog/2016/11/30/ember-2-10-released.html). @@ -330,7 +330,7 @@ class MyManager implements ComponentManager { instance.setProperties(args.named); - return { secret, instance }; + return { immutable, instance }; } // expose the component instance (but not the internal details) as @@ -383,7 +383,7 @@ class PooledManager implements ComponentManager { return instance; } - ... + //... } ``` @@ -398,7 +398,7 @@ with individual features PAYGO (pay-as-you-go). The Glimmer architecture makes it possible to break down the work of component invocation into small pieces. For example, a "template-only component" doesn't need Glimmer to invoke any -the hooks related to lifecycle management of the *component instance*. +of the hooks related to the lifecycle management of the *component instance*. Therefore, in an ideal world, they should not pay the cost associated with invoking those hooks. @@ -427,7 +427,7 @@ const { capabilities, definition } from Ember.Component; export default definition({ name: "foo-bar", capabilities: capabilities("2.13"), - ... + //... }); ``` @@ -474,7 +474,7 @@ export default definition({ someFeature: true, anotherFeature: true }), - ... + //... }); ```