From 721d460dfd245f83be5eb1646931e47cd6f0b49f Mon Sep 17 00:00:00 2001 From: zhiqiang Date: Fri, 30 Aug 2024 11:45:14 +0800 Subject: [PATCH] [chore](cancel) Make enable_pipeline_task_leakage_detect false by default (#40145) add be.conf enable_pipeline_task_leakage_detect, default to false. --- be/src/common/config.cpp | 2 ++ be/src/common/config.h | 2 ++ be/src/runtime/fragment_mgr.cpp | 5 +++-- 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/be/src/common/config.cpp b/be/src/common/config.cpp index f051bb3e8569b0..d6aaeaf6accf1c 100644 --- a/be/src/common/config.cpp +++ b/be/src/common/config.cpp @@ -1320,6 +1320,8 @@ DEFINE_mInt64(pipeline_task_leakage_detect_period_secs, "60"); DEFINE_mInt32(snappy_compression_block_size, "262144"); DEFINE_mInt32(lz4_compression_block_size, "262144"); +DEFINE_mBool(enable_pipeline_task_leakage_detect, "false"); + // clang-format off #ifdef BE_TEST // test s3 diff --git a/be/src/common/config.h b/be/src/common/config.h index 69e17f843e6ba9..017eab0302ac90 100644 --- a/be/src/common/config.h +++ b/be/src/common/config.h @@ -1414,6 +1414,8 @@ DECLARE_mInt64(pipeline_task_leakage_detect_period_secs); DECLARE_mInt32(snappy_compression_block_size); DECLARE_mInt32(lz4_compression_block_size); +DECLARE_mBool(enable_pipeline_task_leakage_detect); + #ifdef BE_TEST // test s3 DECLARE_String(test_s3_resource); diff --git a/be/src/runtime/fragment_mgr.cpp b/be/src/runtime/fragment_mgr.cpp index 32b7dcbcbb226e..a9fb5a2f35229d 100644 --- a/be/src/runtime/fragment_mgr.cpp +++ b/be/src/runtime/fragment_mgr.cpp @@ -951,8 +951,9 @@ void FragmentMgr::cancel_worker() { timespec now; clock_gettime(CLOCK_MONOTONIC, &now); - if (now.tv_sec - check_invalid_query_last_timestamp.tv_sec > - config::pipeline_task_leakage_detect_period_secs) { + if (config::enable_pipeline_task_leakage_detect && + now.tv_sec - check_invalid_query_last_timestamp.tv_sec > + config::pipeline_task_leakage_detect_period_secs) { check_invalid_query_last_timestamp = now; running_queries_on_all_fes = _get_all_running_queries_from_fe(); } else {