This repository was archived by the owner on May 1, 2024. It is now read-only.
Make it possible to customise the window on iOS #1247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request. |
rmarinho
previously requested changes
Nov 2, 2017
Member
rmarinho
left a comment
rmarinho
left a comment
There was a problem hiding this comment.
Some issues with formatting other than that i don't see a problem
samhouts
reviewed
Nov 3, 2017
| var platformRenderer = (PlatformRenderer)_window.RootViewController; | ||
|
|
||
| if (platformRenderer != null) | ||
| if(Window.RootViewController is PlatformRenderer platformRenderer) |
Contributor
There was a problem hiding this comment.
This is C#7, yeah? Love it, but we're stuck in VS2015 land for now. :(
Also, if you make other changes to the file, please also add a space between the if and parens. Not a big deal.
Contributor
Author
There was a problem hiding this comment.
Hmmm ok, i'll make some changes. There is nothing about this in the Wiki on how to contribute.
Contributor
Author
|
@samhouts Implemented requested changes. |
mattleibow
pushed a commit
that referenced
this pull request
Jan 28, 2021
Fixes #1247 Must set SourceRect in iOS 13
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This changes the way the window is used in iOS in a backwards compatible way.
Bugs Fixed
It was not possible to swap out the current root for a native Xamarin ViewController, and then navigate back to a Forms one.
Also when changing the MainPage on a custom window it would crash because it would not implement PlatformRenderer. The new check prevents this.
API Changes
List all API changes here (or just put None), example:
Added:
Behavioral Changes
This will not change any behaviour but just enable to work easier with Native views, especially in MvvmCross.
PR Checklist