This repository was archived by the owner on May 1, 2024. It is now read-only.
[XamlG] do not mess with path separators #1250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
jonathanpeppers
added a commit
to jonathanpeppers/Xamarin.Forms
that referenced
this pull request
May 18, 2018
- `[TearDown]` was throwing on VSTS: https://devdiv.visualstudio.com/DevDiv/_build?buildId=1700425 - Put back the path logic for: xamarin#1250 - Added more tests
PureWeen
pushed a commit
that referenced
this pull request
Oct 24, 2019
mattleibow
pushed a commit
that referenced
this pull request
Jan 28, 2021
Fixes #1247 Must set SourceRect in iOS 13
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
when the targetPath contains a
\, the output file name might end up wrong on Mac.this fixes it
I'm not able to reproduce it in our test project, only on @davidortinau's.
Bugs Fixed
PR Checklist