Skip to content

Commit

Permalink
[tests][intro] Fix protocol results for macOS 12 beta (#12347)
Browse files Browse the repository at this point in the history
IOW move some custom checks from iOS to the base class that also
covers macOS.
  • Loading branch information
spouliot authored Aug 4, 2021
1 parent a91e34f commit fa5f323
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 16 deletions.
18 changes: 18 additions & 0 deletions tests/introspection/ApiProtocolTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,10 @@ protected virtual bool Skip (Type type, string protocolName)
return true;
// Xcode 13
case "HKVerifiableClinicalRecord":
case "PKDeferredPaymentSummaryItem":
case "PKRecurringPaymentSummaryItem":
case "PKStoredValuePassProperties":
case "SNTimeDurationConstraint": // Conformance not in headers
return true;
}
break;
Expand Down Expand Up @@ -250,6 +254,13 @@ protected virtual bool Skip (Type type, string protocolName)
return true;
// Xcode 12.5
case "GCDualSenseGamepad":
// Xcode 13
case "PKDeferredPaymentSummaryItem":
case "PKPaymentRequestCouponCodeUpdate":
case "PKRecurringPaymentSummaryItem":
case "PKStoredValuePassBalance":
case "PKStoredValuePassProperties":
case "SNTimeDurationConstraint": // Conformance not in headers
return true;
}
break;
Expand Down Expand Up @@ -367,6 +378,13 @@ protected virtual bool Skip (Type type, string protocolName)
return true;
// Xcode 12.5
case "GCDualSenseGamepad":
// xcode 13
case "PKDeferredPaymentSummaryItem":
case "PKPaymentRequestCouponCodeUpdate":
case "PKRecurringPaymentSummaryItem":
case "PKStoredValuePassBalance":
case "PKStoredValuePassProperties":
case "SNTimeDurationConstraint": // Conformance not in headers
return true;
}
break;
Expand Down
16 changes: 0 additions & 16 deletions tests/introspection/iOS/iOSApiProtocolTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -441,12 +441,6 @@ protected override bool Skip (Type type, string protocolName)
case "ARSkeletonDefinition": // device only
case "ARVideoFormat": // device only
case "NSMergePolicy":
case "SNTimeDurationConstraint": // Conformance not in headers
case "PKDeferredPaymentSummaryItem":
case "PKPaymentRequestCouponCodeUpdate":
case "PKRecurringPaymentSummaryItem":
case "PKStoredValuePassBalance":
case "PKStoredValuePassProperties":
case "SFSafariViewControllerPrewarmingToken": // conformance not in headers
case "SRTextInputSession": // conformance not in headers
return true;
Expand Down Expand Up @@ -688,12 +682,6 @@ protected override bool Skip (Type type, string protocolName)
case "ARSkeletonDefinition": // device only
case "ARVideoFormat": // device only
case "NSMergePolicy":
case "SNTimeDurationConstraint": // Conformance not in headers
case "PKDeferredPaymentSummaryItem":
case "PKPaymentRequestCouponCodeUpdate":
case "PKRecurringPaymentSummaryItem":
case "PKStoredValuePassBalance":
case "PKStoredValuePassProperties":
case "SFSafariViewControllerPrewarmingToken": // conformance not in headers
case "SRTextInputSession": // conformance not in headers
return true;
Expand Down Expand Up @@ -779,10 +767,6 @@ protected override bool Skip (Type type, string protocolName)
case "NSMappingModel":
case "NSMergePolicy":
case "NSPropertyMapping":
case "SNTimeDurationConstraint": // Conformance not in headers"
case "PKDeferredPaymentSummaryItem":
case "PKRecurringPaymentSummaryItem":
case "PKStoredValuePassProperties":
return true;
}
break;
Expand Down

1 comment on commit fa5f323

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ [CI Build] Tests failed on Build ❌

Tests failed on Build.

API & Generator diff

API Diff (from PR only) (no change)
Generator Diff (only version changes)

Packages generated

View packages

Test results

2 tests failed, 223 tests passed.

Failed tests

  • monotouch-test/watchOS 32-bits - simulator/Debug (all optimizations): Failed
  • Documentation/All: Failed

Pipeline on Agent XAMBOT-1036.BigSur'
[tests][intro] Fix protocol results for macOS 12 beta (#12347)

Please sign in to comment.