[d16-2] [xharness] Don't use a dash in the bundle identifer for watchOS projects. #6118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cts. It causes problems with the mscorlib test project, which can't be launched properly. I'm not sure what's the underlying cause, but here are some of the symptoms: * The watch app actually shows up fine on the device, but: * mlaunch isn't notified about the new process, so it thinks the app didn't launch. * The new process doesn't receive any environment variables we try to give it, which for instance means that it won't auto-start the tests upon launch. * If we ask mlaunch to attach with lldb, mlaunch will ask watchOS to launch the process in a suspended state while lldb attaches. Yet the watch app shows up on the device as if not asked to be suspended upon launch. It seems that the dash (I assume, because I haven't investigated this very deeply, I just happened to find a solution that worked) makes watchOS launch the app as if tapped, instead of launched from an IDE. The strangest part is that this only happens with the mscorlib test project, not any of the other test projects we run on the watch, and they all have dashes in their bundle identifiers... yet replacing the dash with another character (underscore, letter, removing it altogether) all made things work as expected.
dalexsoto
approved these changes
May 23, 2019
rolfbjarne
changed the title
rolfbjarne
added
the
pr-change-not-shipping
spouliot
approved these changes
May 23, 2019
|
Build failure Test results3 tests failed, 0 tests' device not found, 91 tests passed.Failed tests
|
The watchOS bundle ID changed in fc5067e, and the test failure wasn't caught properly.
rolfbjarne
approved these changes
May 24, 2019
|
Build success |
chamons
approved these changes
May 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It causes problems with the mscorlib test project, which can't be launched properly.
I'm not sure what's the underlying cause, but here are some of the symptoms:
launch.
which for instance means that it won't auto-start the tests upon launch.
the process in a suspended state while lldb attaches. Yet the watch app
shows up on the device as if not asked to be suspended upon launch.
It seems that the dash (I assume, because I haven't investigated this very
deeply, I just happened to find a solution that worked) makes watchOS launch
the app as if tapped, instead of launched from an IDE.
The strangest part is that this only happens with the mscorlib test project,
not any of the other test projects we run on the watch, and they all have
dashes in their bundle identifiers... yet replacing the dash with another
character (underscore, letter, removing it altogether) all made things work as
expected.
Backport of #6114.
/cc @rolfbjarne