Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ShazamKit] Add support for Xcode 15 #19005

Merged
merged 7 commits into from
Sep 18, 2023
Merged

[ShazamKit] Add support for Xcode 15 #19005

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8f387dc
[ShazamKit] Add support for Xcode 15
haritha-mohan Sep 12, 2023
c9351bf
Auto-format source code
Sep 12, 2023
76675d6
Update src/shazamkit.cs
mandel-macaque Sep 12, 2023
13d238a
add ignore
haritha-mohan Sep 12, 2023
0413988
Apply suggestions from code review
mandel-macaque Sep 13, 2023
ff464a1
fix versions for SHMediaLibrary deprecated attrs
haritha-mohan Sep 14, 2023
5fa0e7a
Merge branch 'net8.0-xcode15' into net8.0-xcode15-shazamkit
haritha-mohan Sep 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/shazamkit.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ public enum SHErrorCode : long {
CustomCatalogInvalidURL = 301,
MediaLibrarySyncFailed = 400,
InternalError = 500,
MediaItemFetchFailed = 600,
}

[iOS (15, 0), Mac (12, 0), Watch (8, 0), TV (15, 0), MacCatalyst (15, 0)]
Expand Down Expand Up @@ -62,6 +63,9 @@ enum SHMediaItemProperty {
[Watch (9, 0), TV (16, 0), Mac (13, 0), iOS (16, 0), MacCatalyst (16, 0)]
[Field ("SHMediaItemFrequencySkewRanges")]
FrequencySkewRanges,
[Watch (10, 0), TV (17, 0), Mac (14, 0), iOS (17, 0), MacCatalyst (17, 0)]
[Field ("SHMediaItemCreationDate")]
CreationDate,
}

[iOS (15, 0), Mac (12, 0), Watch (8, 0), TV (15, 0), MacCatalyst (15, 0)]
Expand Down Expand Up @@ -190,9 +194,18 @@ interface SHMediaItem : NSSecureCoding, NSCopying {
[Watch (9, 0), TV (16, 0), Mac (13, 0), iOS (16, 0), MacCatalyst (16, 0)]
[Export ("frequencySkewRanges", ArgumentSemantic.Strong)]
SHRange [] FrequencySkewRanges { get; }

[Watch (10, 0), TV (17, 0), Mac (14, 0), iOS (17, 0), MacCatalyst (17, 0)]
[NullAllowed, Export ("creationDate", ArgumentSemantic.Strong)]
NSDate CreationDate { get; }
}

[iOS (15, 0), Mac (12, 0), Watch (8, 0), TV (15, 0), MacCatalyst (15, 0)]
[Deprecated (PlatformName.MacOSX, 12, 0, message: "Use SHLibrary instead.")]
[Deprecated (PlatformName.iOS, 15, 0, message: "Use SHLibrary instead.")]
[Deprecated (PlatformName.TvOS, 15, 0, message: "Use SHLibrary instead.")]
[Deprecated (PlatformName.WatchOS, 8, 0, message: "Use SHLibrary instead.")]
mandel-macaque marked this conversation as resolved.
Show resolved Hide resolved
[Deprecated (PlatformName.MacCatalyst, 15, 0, message: "Use SHLibrary instead.")]
[BaseType (typeof (NSObject))]
[DisableDefaultCtor]
interface SHMediaLibrary {
Expand Down
10 changes: 0 additions & 10 deletions tests/xtro-sharpie/api-annotations-dotnet/MacCatalyst-ShazamKit.todo
View file
Open in desktop

This file was deleted.

4 changes: 0 additions & 4 deletions tests/xtro-sharpie/api-annotations-dotnet/iOS-ShazamKit.todo
View file
Open in desktop

This file was deleted.

4 changes: 0 additions & 4 deletions tests/xtro-sharpie/api-annotations-dotnet/macOS-ShazamKit.todo
View file
Open in desktop

This file was deleted.

4 changes: 0 additions & 4 deletions tests/xtro-sharpie/api-annotations-dotnet/tvOS-ShazamKit.todo
View file
Open in desktop

This file was deleted.

4 changes: 0 additions & 4 deletions tests/xtro-sharpie/iOS-ShazamKit.todo
View file
Open in desktop

This file was deleted.

4 changes: 0 additions & 4 deletions tests/xtro-sharpie/macOS-ShazamKit.todo
View file
Open in desktop

This file was deleted.

4 changes: 0 additions & 4 deletions tests/xtro-sharpie/tvOS-ShazamKit.todo
View file
Open in desktop

This file was deleted.

2 changes: 2 additions & 0 deletions tests/xtro-sharpie/watchOS-ShazamKit.todo → tests/xtro-sharpie/watchOS-ShazamKit.ignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
## xtro being not recognizing
!unknown-field! SHErrorDomain bound
!unknown-field! SHMediaItemAppleMusicID bound
!unknown-field! SHMediaItemAppleMusicURL bound
Expand Down Expand Up @@ -27,3 +28,4 @@
!unknown-type! SHSession bound
!unknown-type! SHSignature bound
!unknown-type! SHSignatureGenerator bound
!unknown-field! SHMediaItemCreationDate bound
Loading