Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaks on single backtick in commit message #4

Closed
max-sixty opened this issue Sep 20, 2023 · 4 comments · Fixed by #5
Closed

Breaks on single backtick in commit message #4

max-sixty opened this issue Sep 20, 2023 · 4 comments · Fixed by #5

Comments

@max-sixty
Copy link

FYI the action breaks on a single backtick in a commit message, for example: https://github.com/pydata/xarray/actions/runs/6242743778/job/16947141657?pr=8216#step:3:25

The commit message was:

And `DataWithCoords

...I had missed the ending backtick

I doubt it's super important... (though possibly it means it can execute code from a commit message? Is that security risk if it's running with secrets? Seems remote but FYI)...

@keewis
Copy link
Collaborator

keewis commented Sep 20, 2023

The issue is that in a final step I'm using echo to print the commit message. However, because the GA variables are expanded before handing it to the shell, which will try to expand them, resulting in the error you're seeing.

To avoid this, I think we can use environment variables. I'll send in a PR.

@keewis
Copy link
Collaborator

keewis commented Sep 20, 2023

@max-sixty
Copy link
Author

Thanks so much!

@keewis
Copy link
Collaborator

keewis commented Sep 20, 2023

I also decided to publish v1.x.1 versions of all releases, because I saw that at least some projects pin the action without having dependabot enabled (not sure if those will be picked up, though)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants