Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make: disable stack protector for BPF bits built by clang #301

Merged
merged 1 commit into from
Mar 4, 2023

Conversation

hhoffstaette
Copy link
Contributor

@hhoffstaette hhoffstaette commented Mar 4, 2023

The clang toolchain might have stack-protection enabled by default (e.g. via platform configuration) and that won't work for BPF, so unconditionally disable it via -fno-stack-protector.
Fixes #299

The clang toolchain might have stack-protection enabled by default
(e.g. via platform configuration) and that won't work for BPF,
so unconfitionally disable it via -fno-stack-protector.

Signed-off-by: Holger Hoffstätte <holger@applied-asynchrony.com>
Copy link
Member

@tohojo tohojo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix! :)

@tohojo tohojo merged commit cb6d062 into xdp-project:master Mar 4, 2023
@hhoffstaette hhoffstaette deleted the nossp branch March 6, 2023 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build error in bpf bits with clang & default-enabled stack protector
2 participants