util: Use bpf_trace_vprintk() directly in sample detection program #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dummy program we use to feature detect for xdp-sample doesn't compile on old versions of libbpf that don't have the macro feature that selects bpf_trace_vprintk() if the number of args exceeds what bpf_trace_printk() supports. To get around this, just use the bpf_trace_vprintk() helper directly, which should hopefully work on old libbpf versions as well. Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dummy program we use to feature detect for xdp-sample doesn't compile
on old versions of libbpf that don't have the macro feature that selects
bpf_trace_vprintk() if the number of args exceeds what bpf_trace_printk()
supports. To get around this, just use the bpf_trace_vprintk() helper
directly, which should hopefully work on old libbpf versions as well.
Fixes #315