transformations: (memref-to-dsd) Support memref.load ops #3338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n-io
added
minor
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3338 +/- ##
==========================================
- Coverage 90.04% 90.04% -0.01%
==========================================
Files 446 446
Lines 56401 56405 +4
Branches 5417 5418 +1
==========================================
Hits 50788 50788
- Misses 4183 4184 +1
- Partials 1430 1433 +3 ☔ View full report in Codecov by Sentry. |
dk949
approved these changes
Oct 24, 2024
EdmundGoodman
pushed a commit
to EdmundGoodman/xdsl
that referenced
this pull request
Dec 6, 2024
…#3338) This pass translates memref allocs to csl array allocs with a get_dsd on top of it, which will be used by various compute ops. This PR add support for memref.load ops, which should continue to load from the memref, not from a get_dsd op. --------- Co-authored-by: n-io <n-io@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pass translates memref allocs to csl array allocs with a get_dsd on top of it, which will be used by various compute ops. This PR add support for memref.load ops, which should continue to load from the memref, not from a get_dsd op.