Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move benchmarks to xdsl-bench and add documentation #3713

Merged
merged 3 commits into from
Jan 8, 2025

Conversation

EdmundGoodman
Copy link
Collaborator

Summary

Remove the benches/ directory, as it now duplicates the content of the xdsl-bench repository, which is the new benchmarking suite under active development and tracking performance regressions at https://xdsl.dev/xdsl-bench/.

Changes

  • Update README to discuss benchmarking
  • Remove benches/ directory
  • Remove asv.conf.json

@EdmundGoodman EdmundGoodman added the testing PRs that modify tests label Jan 7, 2025
@EdmundGoodman EdmundGoodman self-assigned this Jan 7, 2025
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.31%. Comparing base (b943df3) to head (7b2ab87).
Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3713      +/-   ##
==========================================
- Coverage   91.32%   91.31%   -0.01%     
==========================================
  Files         467      468       +1     
  Lines       58543    58546       +3     
  Branches     5652     5652              
==========================================
  Hits        53463    53463              
- Misses       3628     3631       +3     
  Partials     1452     1452              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@superlopuh superlopuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent

@superlopuh superlopuh merged commit 523bb5c into main Jan 8, 2025
16 checks passed
@superlopuh superlopuh deleted the edmundgoodman/move-benchmarks branch January 8, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing PRs that modify tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants