Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backend: (riscv) rename jx registers to j_x #3934

Merged
merged 1 commit into from
Feb 19, 2025
Merged

backend: (riscv) rename jx registers to j_x #3934

merged 1 commit into from
Feb 19, 2025

Conversation

superlopuh
Copy link
Member

No description provided.

@superlopuh superlopuh added the backend Compiler backend in xDSL label Feb 18, 2025
@superlopuh superlopuh self-assigned this Feb 18, 2025
@superlopuh superlopuh mentioned this pull request Feb 18, 2025
Merged
@codecov Codecov
Copy link

codecov bot commented Feb 18, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.30%. Comparing base (0dd5626) to head (3a6ac6d).
Report is 7 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3934   +/-   ##
=======================================
  Coverage   91.30%   91.30%           
=======================================
  Files         467      467           
  Lines       58068    58068           
  Branches     5581     5581           
=======================================
+ Hits        53018    53021    +3     
+ Misses       3618     3616    -2     
+ Partials     1432     1431    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

compor
compor approved these changes Feb 18, 2025
View reviewed changes
Copy link
Collaborator

@compor compor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should wait for @JosseVanDelm ;-]

JosseVanDelm
JosseVanDelm approved these changes Feb 19, 2025
View reviewed changes
Copy link
Collaborator

@JosseVanDelm JosseVanDelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok!

@superlopuh superlopuh merged commit e9b1efb into main Feb 19, 2025
16 checks passed
@superlopuh superlopuh deleted the sasha/riscv/j-underscore branch February 19, 2025 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compor compor compor approved these changes

@JosseVanDelm JosseVanDelm JosseVanDelm approved these changes

@jorendumoulin jorendumoulin Awaiting requested review from jorendumoulin

@AntonLydike AntonLydike Awaiting requested review from AntonLydike

Assignees

@superlopuh superlopuh

Labels
backend Compiler backend in xDSL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@superlopuh @compor @JosseVanDelm