feat(arc): add optional arg for filename in gscobj header #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diamante0018
suggested changes
Oct 2, 2023
include/xsk/arc/assembler.hpp
Outdated
| @@ -25,7 +25,7 @@ class assembler | |||
|
|
|||
| public: | |||
| assembler(context const* ctx); | |||
| auto assemble(assembly const& data) -> buffer; | |||
| auto assemble(assembly const& data, std::string const& string = "") -> buffer; | |||
There was a problem hiding this comment.
Empty string should be initialized with empty braces rather than "" due to clang bug that was discovered by me and some other people.
diamante0018
approved these changes
Oct 2, 2023
xensik
approved these changes
Oct 2, 2023
include/xsk/arc/assembler.hpp
Outdated
| @@ -25,7 +25,7 @@ class assembler | |||
|
|
|||
| public: | |||
| assembler(context const* ctx); | |||
| auto assemble(assembly const& data) -> buffer; | |||
| auto assemble(assembly const& data, std::string const& string = {}) -> buffer; | |||
There was a problem hiding this comment.
rename the parameter to a meaningful name, like 'name'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows integrations of gsc-tool to pass the filename to the assembler.