Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auth middleware #126

Merged
merged 3 commits into from
Apr 4, 2022
Merged

Add auth middleware #126

merged 3 commits into from
Apr 4, 2022

Conversation

mtrinh11
Copy link
Contributor

adds new middleware for adding to the logger post bascule processing

@codecov
Copy link

codecov bot commented Mar 31, 2022

Codecov Report

Merging #126 (f7d3867) into main (7e3d13a) will increase coverage by 0.01%.
The diff coverage is 40.00%.

❗ Current head f7d3867 differs from pull request most recent head 3f39417. Consider uploading reports for the commit 3f39417 to get more accurate results

@@            Coverage Diff             @@
##             main     #126      +/-   ##
==========================================
+ Coverage   81.32%   81.33%   +0.01%     
==========================================
  Files          44       44              
  Lines        1403     1404       +1     
==========================================
+ Hits         1141     1142       +1     
+ Misses        235      234       -1     
- Partials       27       28       +1     
Impacted Files Coverage Δ
basculehttp/log.go 45.71% <25.00%> (+0.78%) ⬆️
basculehttp/chain.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e3d13a...3f39417. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Mar 31, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

25.0% 25.0% Coverage
0.0% 0.0% Duplication

@mtrinh11 mtrinh11 requested a review from kristinapathak March 31, 2022 22:52
@mtrinh11 mtrinh11 merged commit 577abcb into main Apr 4, 2022
@mtrinh11 mtrinh11 deleted the addAuthMiddleware branch April 4, 2022 22:15
@denopink denopink mentioned this pull request Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants