Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch SetLogger Bug: Shared logger among requests creates repeating logging context #160

Merged
merged 2 commits into from
Nov 11, 2022
Merged

Patch SetLogger Bug: Shared logger among requests creates repeating logging context #160

merged 2 commits into from
Nov 11, 2022

Conversation

denopink
Copy link
Contributor

@denopink denopink added the bug Something isn't working label Nov 10, 2022
@denopink denopink requested review from johnabass and ilawjr November 10, 2022 19:52
@denopink denopink self-assigned this Nov 10, 2022
@denopink denopink requested review from renaz6 and removed request for ilawjr November 10, 2022 19:53
@codecov
Copy link

codecov bot commented Nov 10, 2022 •
edited
Loading

Codecov Report

Merging #160 (595dca8) into main (d3c43a9) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main     #160   +/-   ##
=======================================
  Coverage   89.67%   89.67%           
=======================================
  Files          35       35           
  Lines        1230     1230           
=======================================
  Hits         1103     1103           
  Misses        110      110           
  Partials       17       17
Flag Coverage Δ
unittests 89.67% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
basculehttp/log.go 45.23% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

johnabass
johnabass requested changes Nov 10, 2022
View reviewed changes
basculehttp/log.go Outdated Show resolved Hide resolved
@johnabass johnabass self-requested a review November 10, 2022 22:10
@sonarcloud
Copy link

sonarcloud bot commented Nov 10, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@denopink denopink merged commit 29df941 into main Nov 11, 2022
@denopink denopink deleted the denopink/patch/bug-repeating-context branch November 11, 2022 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renaz6 renaz6 renaz6 approved these changes

@johnabass johnabass johnabass approved these changes

Assignees

@denopink denopink

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@denopink @johnabass @renaz6