Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplified attributes #64

Merged
merged 3 commits into from
Oct 6, 2020
Merged

simplified attributes #64

merged 3 commits into from
Oct 6, 2020

Conversation

kristinapathak
Copy link
Contributor

fixes #63

@kristinapathak kristinapathak added the bug Something isn't working label Sep 28, 2020
@kristinapathak kristinapathak added this to the Unreleased milestone Sep 28, 2020
@kristinapathak kristinapathak self-assigned this Sep 28, 2020
Copy link
Contributor

@johnabass johnabass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and simple, good idea there

@codecov
Copy link

codecov bot commented Oct 6, 2020

Codecov Report

Merging #64 into main will decrease coverage by 2.71%.
The diff coverage is 81.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #64      +/-   ##
==========================================
- Coverage   78.82%   76.11%   -2.72%     
==========================================
  Files          25       26       +1     
  Lines         836      649     -187     
==========================================
- Hits          659      494     -165     
+ Misses        158      137      -21     
+ Partials       19       18       -1     
Impacted Files Coverage Δ
token.go 100.00% <ø> (+2.06%) ⬆️
basculehttp/tokenFactory.go 45.00% <14.28%> (-3.39%) ⬇️
attributes.go 100.00% <100.00%> (ø)
checks.go 100.00% <100.00%> (+4.34%) ⬆️
basculehttp/notfoundbehavior_string.go 16.66% <0.00%> (-8.34%) ⬇️
key/cache.go 85.71% <0.00%> (-2.75%) ⬇️
acquire/auth.go 87.50% <0.00%> (-2.50%) ⬇️
key/parser.go 76.74% <0.00%> (-1.98%) ⬇️
key/resolver.go 86.66% <0.00%> (-1.91%) ⬇️
acquire/bearer.go 87.50% <0.00%> (-1.18%) ⬇️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97ae895...c2dc055. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Oct 6, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

82.4% 82.4% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@johnabass johnabass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@kristinapathak kristinapathak merged commit fa01ecb into main Oct 6, 2020
@kristinapathak kristinapathak deleted the token branch October 6, 2020 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attributes should be case sensitive
2 participants