Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exiting dispatcher() on a cutoff #208

Closed
kristinapathak opened this issue May 13, 2020 · 0 comments · Fixed by #210
Closed

Exiting dispatcher() on a cutoff #208

kristinapathak opened this issue May 13, 2020 · 0 comments · Fixed by #210
Assignees
Labels
Milestone

Comments

@kristinapathak
Copy link
Contributor

Once we cut a webhook off, the long running goroutine dispatcher() exits. Until this outbound sender goes away and we make a new one for the webhook, they'll never get another message from us.

break Loop

We shouldn't break here; instead there should be a continue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant