-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed dispatcher() on cutoff conditions #210
Conversation
Codecov Report
@@ Coverage Diff @@
## master #210 +/- ##
==========================================
+ Coverage 69.27% 69.67% +0.40%
==========================================
Files 7 7
Lines 742 742
==========================================
+ Hits 514 517 +3
+ Misses 216 214 -2
+ Partials 12 11 -1
Continue to review full report at Codecov.
|
Remove the |
We need Line 470 in b887423
Otherwise, we would just |
@@ -480,7 +480,7 @@ Loop: | |||
|
|||
if now.Before(dropUntil) { | |||
obs.droppedCutoffCounter.Add(1.0) | |||
break Loop | |||
continue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works, but do we still need the Loop
label at all?
Quick thought: Seems like this code never exits now, which isn't much of an issue if we never intend to quiesce/restart it.
I think we still need the |
fixes #208