Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed dispatcher() on cutoff conditions #210

Merged
merged 2 commits into from
May 14, 2020
Merged

fixed dispatcher() on cutoff conditions #210

merged 2 commits into from
May 14, 2020

Conversation

kristinapathak
Copy link
Contributor

fixes #208

@kristinapathak kristinapathak added this to the Unreleased milestone May 13, 2020
@kristinapathak kristinapathak self-assigned this May 13, 2020
@codecov
Copy link

codecov bot commented May 13, 2020

Codecov Report

Merging #210 into master will increase coverage by 0.40%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #210      +/-   ##
==========================================
+ Coverage   69.27%   69.67%   +0.40%     
==========================================
  Files           7        7              
  Lines         742      742              
==========================================
+ Hits          514      517       +3     
+ Misses        216      214       -2     
+ Partials       12       11       -1     
Impacted Files Coverage Δ
outboundSender.go 84.31% <0.00%> (+0.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0723afd...603c5f1. Read the comment docs.

@schmidtw
Copy link
Member

Remove the Loop: label.

@kristinapathak
Copy link
Contributor Author

We need Loop: for this line though:

break Loop

Otherwise, we would just break out of the select statement. Is there a better way to do this?

@@ -480,7 +480,7 @@ Loop:

if now.Before(dropUntil) {
obs.droppedCutoffCounter.Add(1.0)
break Loop
continue
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works, but do we still need the Loop label at all?

Quick thought: Seems like this code never exits now, which isn't much of an issue if we never intend to quiesce/restart it.

@gargidb
Copy link
Contributor

gargidb commented May 13, 2020

I think we still need the Loop label to break out if the queue is empty.

@kristinapathak kristinapathak merged commit 76e8eab into master May 14, 2020
@kristinapathak kristinapathak deleted the fix-cutoff branch May 14, 2020 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exiting dispatcher() on a cutoff
4 participants