Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make rules more generic #100

Open
kristinapathak opened this issue Jul 16, 2019 · 2 comments
Open

Make rules more generic #100

kristinapathak opened this issue Jul 16, 2019 · 2 comments
Labels
enhancement New feature or request needs discussion

Comments

@kristinapathak
Copy link
Contributor

Rules are used to determine whether or not to parse the device id from the source or destination of the wrp. If the device id should be parsed from the destination, the rule should have a regular expression stating how to parse the destination. As long as that isn't empty, the destination should be used to get the device id for events following that rule. For any events with rules not specifying a regular expression or events that don't have a rule, the source should be used.

@kristinapathak kristinapathak added the enhancement New feature or request label Jul 16, 2019
@kcajmagic kcajmagic added hacktoberfest https://comcast.github.io/hacktoberfest good first issue Good for newcomers labels Oct 8, 2019
@kcajmagic kcajmagic removed their assignment Oct 8, 2019
@kristinapathak kristinapathak removed the hacktoberfest https://comcast.github.io/hacktoberfest label Nov 1, 2019
@kristinapathak
Copy link
Contributor Author

We want to be able to:

  • parse against any field to determine the type
  • rule should include the location and regex for parsing the device id

@kristinapathak
Copy link
Contributor Author

We need to revisit what we want to do with this, given we won't need to parse the device ID anymore. We still probably want to only keep the payload on certain types of messages, and possibly keep the different TTL options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs discussion
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants