Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pruned dgrijalva dependency from themis itself #78

Merged
merged 2 commits into from
Aug 30, 2021
Merged

Conversation

johnabass
Copy link
Contributor

Replaced github.com/dgrijalva/jwt-go with github.com/golang-jwt/jwt

@johnabass johnabass requested a review from joe94 July 13, 2021 19:23
@sonarcloud
Copy link

sonarcloud bot commented Jul 13, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Jul 13, 2021

Codecov Report

Merging #78 (a1433de) into main (f11826e) will increase coverage by 1.47%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #78      +/-   ##
==========================================
+ Coverage   81.36%   82.83%   +1.47%     
==========================================
  Files          43       43              
  Lines        1293     1515     +222     
==========================================
+ Hits         1052     1255     +203     
- Misses        221      240      +19     
  Partials       20       20              
Impacted Files Coverage Δ
token/factory.go 92.00% <ø> (+1.52%) ⬆️
xlog/xloghttp/request.go 95.74% <0.00%> (-1.40%) ⬇️
token/transport.go 93.44% <0.00%> (-0.79%) ⬇️
routes.go 11.94% <0.00%> (-0.13%) ⬇️
main.go 0.00% <0.00%> (ø)
client.go 0.00% <0.00%> (ø)
metrics.go 0.00% <0.00%> (ø)
xlog/log.go 100.00% <0.00%> (ø)
key/handler.go 100.00% <0.00%> (ø)
key/provide.go 100.00% <0.00%> (ø)
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f11826e...a1433de. Read the comment docs.

@joe94 joe94 merged commit bef8acb into main Aug 30, 2021
@joe94 joe94 deleted the feature/golang-jwt branch August 30, 2021 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants