Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch: ParseLocator, sanitize locator components #211

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

denopink
Copy link
Contributor

  • currently, parsing the following string "event: /xmidt-test/2/config" yields an authority with the value
  • sanitize each locator component, removing trailing and leading whitespaces

- currently, parsing the following string "event:     /xmidt-test/2/config" yields an authority with the value `     `
 - sanitize each locator component, removing trailing and leading whitespaces

#210
@denopink denopink requested a review from schmidtw October 18, 2024 20:36
@denopink denopink self-assigned this Oct 18, 2024
@denopink denopink added the bug Something isn't working label Oct 18, 2024
@denopink denopink linked an issue Oct 18, 2024 that may be closed by this pull request
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.03%. Comparing base (2e1866f) to head (c6482be).
Report is 41 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #211      +/-   ##
==========================================
+ Coverage   52.89%   53.03%   +0.13%     
==========================================
  Files          32       32              
  Lines        4902     4910       +8     
==========================================
+ Hits         2593     2604      +11     
+ Misses       2115     2113       -2     
+ Partials      194      193       -1     
Flag Coverage Δ
unittests 53.03% <100.00%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@schmidtw schmidtw merged commit 65bfda2 into main Oct 18, 2024
19 checks passed
@schmidtw schmidtw deleted the denopink/feat/locator-remove-leading_tailing-spaces branch October 18, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ParseLocator: sanitize locator components
2 participants