Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Model caching #253

Merged
merged 10 commits into from
Dec 2, 2024
Merged

Model caching #253

merged 10 commits into from
Dec 2, 2024

Conversation

roussel-ryan
Copy link
Collaborator

  • implements use_cached_hyperparameters flag inside model constructor, which bypasses model training and uses state_dict of the last trained GP model instead
  • updated time dependent BO example with caching usage

nikitakuklev
nikitakuklev approved these changes Nov 21, 2024
View reviewed changes
Copy link
Collaborator

@nikitakuklev nikitakuklev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, need to check carefully at where tensor live since state_dict is a shallow copy

@roussel-ryan roussel-ryan merged commit 0b8c706 into main Dec 2, 2024
14 checks passed
@roussel-ryan roussel-ryan deleted the model_caching branch December 2, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikitakuklev nikitakuklev nikitakuklev approved these changes

@ChristopherMayes ChristopherMayes ChristopherMayes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roussel-ryan @nikitakuklev @ChristopherMayes