This repository has been archived by the owner on Nov 14, 2023. It is now read-only.
feat: Add InputDropdown. #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for wizard-ui ready! Built with commit 6f9ce30 |
Codecov Report
@@ Coverage Diff @@
## master #64 +/- ##
==========================================
+ Coverage 76.94% 78.07% +1.12%
==========================================
Files 29 30 +1
Lines 937 967 +30
Branches 195 201 +6
==========================================
+ Hits 721 755 +34
+ Misses 214 210 -4
Partials 2 2
Continue to review full report at Codecov.
|
added 3 commits
August 23, 2019 16:57
wangkailang
suggested changes
Aug 27, 2019
| if (input && input.value !== undefined) { | ||
| return input.value; | ||
| } | ||
| return value !== undefined ? value : defaultValue; |
There was a problem hiding this comment.
return value || defaultValue
There was a problem hiding this comment.
这么写和原逻辑就不一致了，value 为 0，空字符串都会返回 defaultValue 了。
|
|
added 4 commits
August 28, 2019 11:03
# Conflicts: # src/interface.tsx
|
高度不一致是由于 sass 精度导致的，修改对应 loader config 就好了 |
wangkailang
approved these changes
Aug 30, 2019
wangkailang
approved these changes
Aug 30, 2019
wangkailang
added a commit
that referenced
this pull request
Sep 2, 2019
…al-select-box * 'master' of github.com:xsky-fe/wizard-ui: Release 0.2.0 feat: Add InputDropdown. (#64) # Conflicts: # src/interface.tsx
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.