Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Adding MSDE PBs for isolation and unisolation for devices (demisto#16144
) * Added new files: - MSDE playbooks for isolation and unisolations - new images of all playbooks - README files Modified: - Common playbooks for isolation and unisolation * . * Update RN * Changes on the PB for dealing with incorrect Device IDs * Changes on the PB - adding support for Hostname and IP * Updated RN * Fixed Issue with Task #3 in the Unisolate (filters were incorrect). * Additional fix - added else on task 26 * Applied PR comments * Applied PR comments * Applied PR comments * Updated RN for MSDE pack * Fixed issues with validation * Changed "devices" --> "device" * Added !endpoint instead the enrichment that was done through the native MSDE commands * Fixed conflicts + Updated RN * Fix Format issues * Fix RN issues * Fix dependencies * Fix dependencies * Updated RN * Updated RN * Merge from master + Resolve conflicts + Resolve comments * Updated RN * Update playbook-Isolate_Endpoint_-_Generic_V2.yml Doc review complete for this file, updated descriptions. * Update playbook-Isolate_Endpoint_-_Generic_V2_README.md doc review complete for this file. Updated descriptions to align with the yaml file. * Update playbook-Isolate_Endpoint_-_Generic_V2.yml minor additional update * Update playbook-Unisolate_Endpoint_-_Generic.yml Doc review complete for this file, updated descriptions. * Update playbook-Unisolate_Endpoint_-_Generic_README.md Doc review complete for this file, aligned the descriptions with the yaml file. * Update 2_2_0.md Doc review complete for this file, minor formatting updates. * Update playbook-Microsoft_Defender_For_Endpoint_-_Isolate_Endpoint.yml Doc review complete for the playbook-Microsoft_Defender_For_Endpoint_-_Isolate_Endpoint.yml file. @ssokolovich please confirm the following: - Lines 314, 368, 591, 645, 695 - the description for **Set Active Device** , **Set Non-valid Devices**, **Set Incorrect ID**, **Set Incorrect IP**, **Set Incorrect Hostname** is "Set a value in context under the key you entered. If no value is entered, the script doesn't do anything. This automation runs using the default Limited User role, unless you explicitly change the permissions. For more information, see the section about permissions here: https://docs.paloaltonetworks.com/cortex/cortex-xsoar/6-2/cortex-xsoar-admin/playbooks/automations.html" This description is generic - should there be descriptions specific to these tasks? - Line 500 - the description for **Check if there is any provided incorrect info** is "Check if there are any incorrect device IDs." - is this correct (incorrect info = incorrect device ID)? - Line 903 - the description for **Was any data provided?** is "'Validate/Enrich inputs through !endpoint'" - this looks like a boolean task. Is it that if it returns yes, then the playbook returns the data? * Update playbook-Microsoft_Defender_For_Endpoint_-_Unisolate_Endpoint.yml Doc review complete for the playbook-Microsoft_Defender_For_Endpoint_-_Unisolate_Endpoint.yml file. @ssokolovich - please confirm the following: - Lines 278, 333, 501, 551, 605 - the description for **Set Unisolate list**, **Set Inactive Device list**, **Set Incorrect IP**, **Set Incorrect Hostname**, **Set Incorrect ID** is generic, should it be more specific? - Line 399 - the simple description for **Print those that can't be unisolated as are not active** is "The following devices can't be isolated...." - shouldn't it be "The following devices can't be unisolated..."? - Line 659 - the description for **Check if there is any provided incorrect info** is "Check if there are any incorrect device IDs." - is incorrect info = incorrect device ID? - Line 904 - the description for **Was any data provided?** is "'Validate/Enrich inputs through !endpoint'" - is this description correct? * Update 1_6_2.md doc review complete for this file. Minor formatting update * Update 1_6_3.md doc review complete for this file, minor formatting update * Update 1_6_2.md additional minor update * Update 1_7_0.md doc review complete for this file, aligned descriptions with the yaml files. * Update RN * Update Yml description * Update Yml description Co-authored-by: julieschwartz18 <91824591+julieschwartz18@users.noreply.github.com>
- Loading branch information