-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revamp widget connector #391
Merged
Merged
Changes from 1 commit
Commits
Show all changes
48 commits
Select commit
Hold shift + click to select a range
10e6dd4
Serialize non-scalar values when inserting meta
westonruter cc03d23
Eliminate reference to undefined variable
westonruter 025e38d
Refactor widgets connector to track bulk changes and to add support f…
westonruter 8ecc107
Fix detection for sorted action
westonruter 7d1c452
Track widget movement to other sidebars
westonruter fecc29f
Use alternate summary template for handle_widget_reordering
westonruter 0aa257f
Filter-out non-scalars from being applied to summary tpl
westonruter e52ea0f
Update addition and deletion handlers to use new summary tpl
westonruter 339aaf2
Re-work widget update callback to also track creates and deletes
westonruter c010105
Fix logic for looking up a multi widget instance
westonruter dccd400
Prevent widget movement record if dealing with active/inactive widgets
westonruter 7ba6ba7
Fix widget object lookup for newly-created widgets
westonruter 01d4c4a
Turn deleted action into removed action for removing widget from sidebar
westonruter d4983c8
Remove moved action
westonruter 2337ca7
Skip logging created and deleted actions by default
westonruter d9dd001
Break up moved record into one removed and one added record
westonruter a48e492
Use experimental phpcs rule subset
westonruter 67e2139
Make the PHPCS WordPress ruleset directory
westonruter 870fd53
Apply PHPCS fixes and some phpDoc improvements
westonruter f792fe9
Merge branch 'master' into widget-customizer
westonruter 9f85ce9
Merge branch 'develop' into widget-customizer
westonruter 6ba3888
Allow PHPCS and WPCS to pull from different locations
westonruter 6b35ebe
Merge branch 'phpcs-improvements' into widget-customizer
westonruter 948280e
Fix .travis.yml syntax error
westonruter d1a5186
Add xss ok for phpcs
westonruter aa81069
Use .ci-env.sh (nee .travis.before_script.sh) in pre-commit hook
westonruter aabe9f8
Merge branch 'develop' into widget-customizer
westonruter 297ccf0
Collapse changes to sidebars_widgets in customizer
westonruter 8f3f088
Fix PHPCS issues
westonruter af2dfda
Merge branch 'plugin-dev-lib' into widget-customizer
westonruter 2d172cb
Eliminate apply_tpl_vars(), and restore use of _x()
westonruter 02309a2
Combined removed/added actions into one moved action
westonruter ca2c47d
Merge branch 'develop' into widget-customizer
westonruter 6f3c39f
Reference sidebar_id instead of sidebar streammeta
westonruter 033c3a7
Merge branch 'develop' into widget-customizer
frankiejarrett 42ca9e1
Code formatting
frankiejarrett f78fc45
Merge develop into widget-customizer
frankiejarrett 80e5c31
Summary improvements to widgets added
frankiejarrett 8f15fe5
Summary tweak for widgets reordered
frankiejarrett 64c6bb4
Summary improvements for widgets moved
frankiejarrett 849d2c6
Summary improvements for widgets updated
frankiejarrett 3b87954
Summary improvements for widgets created
frankiejarrett 5e52f17
No need for Sidebar Name in widget created/deleted summaries
frankiejarrett e31de41
Reordering vars for consistency
frankiejarrett b8624e4
Summary improvements for widgets removed
frankiejarrett ed8f623
Summary improvements for widgets reactivated
frankiejarrett 4527a59
Summary improvements for widgets deactivated
frankiejarrett 3b134b1
Widget summary grammar tweaks
frankiejarrett File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Turn deleted action into removed action for removing widget from sidebar
Fix typo in logging deletions
- Loading branch information
commit 01d4c4a28aa31ddb56d3478a9b89a1f578362736
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this was addressed in 297ccf0.