fixed evaluateAbsolutePosition for nested nodes

xyflow · Nov 4, 2024 · 323e1b3 · 323e1b3
1 parent 49e74dc
commit 323e1b3
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 10 deletions.
diff --git a/.changeset/wet-hounds-reply.md b/.changeset/wet-hounds-reply.md
@@ -0,0 +1,7 @@
+---
+'@xyflow/system': patch
+'@xyflow/react': patch
+'@xyflow/svelte': patch
+---
+
+Fix node intersections in nested flow.
diff --git a/packages/system/src/utils/general.ts b/packages/system/src/utils/general.ts
@@ -252,18 +252,13 @@ export function evaluateAbsolutePosition(
   nodeLookup: NodeLookup,
   nodeOrigin: NodeOrigin
 ): XYPosition {
-  let nextParentId: string | undefined = parentId;
   const positionAbsolute = { ...position };
 
-  while (nextParentId) {
-    const parent = nodeLookup.get(nextParentId);
-    nextParentId = parent?.parentId;
-
-    if (parent) {
-      const origin = parent.origin || nodeOrigin;
-      positionAbsolute.x += parent.internals.positionAbsolute.x - (dimensions.width ?? 0) * origin[0];
-      positionAbsolute.y += parent.internals.positionAbsolute.y - (dimensions.height ?? 0) * origin[1];
-    }
+  const parent = nodeLookup.get(parentId);
+  if (parent) {
+    const origin = parent.origin || nodeOrigin;
+    positionAbsolute.x += parent.internals.positionAbsolute.x - (dimensions.width ?? 0) * origin[0];
+    positionAbsolute.y += parent.internals.positionAbsolute.y - (dimensions.height ?? 0) * origin[1];
   }
 
   return positionAbsolute;