-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pointer-events-support): Add support for pointer events and the ability to opt-out of implicit pointer capturing #3169
base: main
Are you sure you want to change the base?
Conversation
@moklick have you had a chance to take a look at this pull request yet? |
Hey @calebpeterson thanks for your PR! we are currently in a feature freeze for v11, because we are already working on the v12 release https://github.com/wbkd/react-flow#-upcoming-changes I will leave this open as a reminder for myself to check if this is something we should support in the next version. |
Thank you so much @moklick! Should I update anything in this PR to make it easier for you to consider/merge it? Do you have any idea of a timeline? |
I need to check if there are any downsides with this approach. When I see it right, pointer events are enabled by default with this PR. Could this affect the performance? |
I hadn't thought about that angle on performance @moklick 🤔 After doing some looking, here's my conclusion: Since the I suppose there are the additional calls to |
@moklick when you have a minute, may I please have an update on if/when we might be able to get this merged? I realize it depends on the feature freeze for v12, but wondered how the timeline for that is looking... Thank you in advance! |
Hey @calebpeterson we are planning to launch in 4 - 6 weeks. Couldn't you already use those events inside your custom nodes? |
Issue
When using a
reactflow
in a mobile browser, touch enter/move/leave events are not handled.Solution
Resources