feat: add XYError
#4540
Open
feat: add XYError
#4540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3ac7650 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
BcakmakogluAI
force-pushed
the
feat/xy-error
branch
from
caf58f9 to
275deea
Compare
BcakmakogluAI
force-pushed
the
feat/xy-error
branch
from
69b715e to
f81a242
Compare
|
Thanks for your help @bcakmakoglu . When I see it right this wouldn't be a breaking change anymore, since you just added another param to the onError function. Is that correct? |
|
@moklick yep, that is correct :) Seems like a conflict came up though, I'll update the PR asap |
BcakmakogluAI
force-pushed
the
feat/xy-error
branch
2 times, most recently
from
d2cba01 to
78e0a63
Compare
|
Could probably be improved by passing |
BcakmakogluAI
force-pushed
the
feat/xy-error
branch
from
78e0a63 to
6061ddd
Compare
bcakmakoglu
force-pushed
the
feat/xy-error
branch
2 times, most recently
from
b6eb282 to
fd402bf
Compare
bcakmakoglu
force-pushed
the
feat/xy-error
branch
from
fd402bf to
3ac7650
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 What's changed?
XYErrorclass to handle errorsXYErrorCodeenum to handle assignable error codesisXYErrorutility function to check if an error is an instance ofXYErrorXYErroras third argument for theonErrorcallbackXYErrorwhen handling errors and pass it to theonErrorcallback🌻 Resolves
XYFlowErrorthat provides error arguments and allows for easier discerning of errors #4539