Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Update all dev-dependencies #4672

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

peterkogo
Copy link
Member

In the process of getting rid of the false-alarm security advisories on the repository, I took the time to simply update all the dev dependencies in the mono repo, and check if any major releases broke something - they did not.

Copy link

changeset-bot bot commented Sep 19, 2024

⚠️ No Changeset found

Latest commit: a64a554

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@peterkogo
Copy link
Member Author

2 new typescript errors popped up.

  • nodes.values().next().value.selected: object might be undefined. Fixed by: nodes.values().next().value?.selected
  • For some reason PropsWIthoutRef got more strict when forwarding refs. To be fair, our type was indeed not 100% correct but props > propWithoutRef

Anyway, both seem pretty minor but I am not sure if this warrants a minor/patch because the type was changed slightly.

@peterkogo peterkogo marked this pull request as draft September 23, 2024 12:29
@moklick
Copy link
Member

moklick commented Sep 23, 2024

We still support React 17. This change would drop support for React17 types. Is the PropsWithoutRef change related or does it with with 17 types, too?

@peterkogo
Copy link
Member Author

peterkogo commented Sep 24, 2024

That might be the culprit. I did not realize that React 17 support is managed over those dependencies.

@peterkogo
Copy link
Member Author

peterkogo commented Sep 26, 2024

Learnings:

  • We can't update past Rollup ^4.22.4 because we will get Typescript outDir to Rollup file mismatch error. With our current setup it's probably not fixable. [@rollup/plugin-typescript] tsconfig declarationDir is ignored when using single file output rollup/plugins#1230
  • We can't update to ESlint 9 because setting ESLINT_USE_FLAT_CONFIG=false does not work and there are flat configs for certain libraries missing (like turbo)
  • Newest typescript version pose compatibility problems (at least we now have 1 typescript version across the project)
  • sometimes you need to delete all node_modules and run 'pnpm prune store' because it just does not do what it should...
  • Using meta or backspace keys in playwright on Webkit does not work
  • e2e is equally the most reliable and most unreliable type of testing

@peterkogo peterkogo marked this pull request as ready for review September 26, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants